Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for kombu #1327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for kombu #1327

wants to merge 1 commit into from

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Mar 20, 2025 •
edited
Loading

Overview

Add message broker support for Kombu.

This includes the addition of two settings:

  • kombu.consumer.enabled - this enables instrumentation specifically for the Kombu consumer. Existing customers that use Celery may otherwise see duplicated transactions when consuming messages-one from Kombu and one from Celery.
  • kombu.ignored_exchanges - this contains a default to ignore the celeryev queue which is a monitoring queue for rabbitmq. Monitoring this queue by default just creates a lot of noise.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2025 •
edited
Loading

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 7 0 0 0.75s
✅ MARKDOWN markdown-link-check 7 0 13.15s
❌ PYTHON ruff yes yes 1 0.21s
✅ YAML prettier 10 1 0 0.75s
✅ YAML v8r 10 0 4.44s
✅ YAML yamllint 10 0 0.55s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hmstepanek hmstepanek force-pushed the add-kombu-support branch 2 times, most recently from 619e3d7 to 14828ef Compare March 25, 2025 00:42
@hmstepanek hmstepanek marked this pull request as ready for review March 25, 2025 00:45
@hmstepanek hmstepanek requested a review from a team as a code owner March 25, 2025 00:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.81395% with 57 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (69fccdc) to head (bc6c478).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/hooks/messagebroker_kombu.py 49.10% 50 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
- Coverage   81.32%   81.17%   -0.15%     
==========================================
  Files         203      204       +1     
  Lines       22641    22768     +127     
  Branches     3574     3594      +20     
==========================================
+ Hits        18413    18483      +70     
- Misses       3034     3085      +51     
- Partials     1194     1200       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-conflicts tests-failing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmstepanek @codecov-commenter